Fix knownhosts key mismatch regression bug in go-git
#921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
added
bug
|
Closing in favour of: #923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins go-git to a version where the following changes have been reverted:
releases/v5.xgo-git/go-git#1482The above changes broken the known hosts verification of GitLab servers using
ssh-rsa,ssh-ed25519and any other host key algo besidesecdsa-sha2-nistp256.Refs:
knownhosts key mismatchregression bug in go-git source-controller#1828Release candidate images:
ghcr.io/fluxcd/image-automation-controller:rc-a986109bdocker.io/fluxcd/image-automation-controller:rc-a986109b